Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XDG Base Directory Specification support #499

Closed
wants to merge 1 commit into from

Conversation

mixedCase
Copy link

Closes #407.

@ben-z
Copy link

ben-z commented May 10, 2020

Sorry to bring up an old PR.. But why is this still not merged?

ben-z added a commit to ben-z/ssr that referenced this pull request May 10, 2020
@MaartenBaert
Copy link
Owner

It breaks compatibility for existing users and causes confusion because of all the earlier posts which instruct users to edit their settings or post their log files which will end up in a completely different (and harder to find) location, while providing no user-visible benefits. I agree that it would have been better to use the XDG directories from the start, but at this point the disadvantages far outweigh the benefits.

@mixedCase
Copy link
Author

This PR migrates the data. In hindsight (this was 4 years ago after all) I would've simply added some indirection to allow backwards compatibility with HOME-polluting configs while creating new configs in according to the proper OS standards. That would still not satisfy @MaartenBaert regarding docs but would fix things without breaking the program.

Alas, I have moved to OBS since so I'll leave that to someone else. I'm closing this PR.

@mixedCase mixedCase closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect XDG base directory specification
3 participants