Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package update, add missing dependency chardet #75

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ dist
.tox/
.coverage
coverage.xml
.idea/

# caches
.mypy_cache/
Expand Down
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ before_cache:
jobs:
include:
# linux
- python: '3.9'
script: python3 -m tox -e py39 -- --cov-report=xml
Comment on lines +17 to +18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

- python: '3.8'
script: python3 -m tox -e py38 -- --cov-report=xml
- python: '3.7'
Expand Down
33 changes: 17 additions & 16 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@ verify_ssl = true

[dev-packages]
pipenv-setup = {editable = true,path = "."}
pytest = {markers = "python_version>='3.6'",version = "~=5.2"}
pytest-mypy = {markers = "python_version>='3.5'",version = "~=0.3"}
pytest-cov = "~=2.7"
pytest-datadir = "~=1.3"
pytest-xdist = "~=1.29"
tox = "~=3.14"
autopep8 = "~=1.4"
pytest = "*"
pytest-mypy = "*"
pytest-cov = "*"
pytest-datadir = "*"
pytest-xdist = "*"
tox = "*"
autopep8 = "*"

[packages]
pipfile = "~=0.0"
black = {markers = "python_version>='3.6'",version = "==19.10b0"}
colorama = "~=0.4"
packaging = "~=20.0"
requirementslib = "~=1.5"
vistir = "~=0.4"
autopep8 = {markers = "python_version<'3.6'",version = "~=1.4"}
six = "~=1.12"
typing = {markers = "python_version<'3.7'", version = "~=3.7"}
pipfile = "*"
black = {markers = "python_version>='3.6'",version = "==21.9b0"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not leave black unpinned here?

Suggested change
black = {markers = "python_version>='3.6'",version = "==21.9b0"}
black = {markers = "python_version>='3.6'", version="*"}

Pinning It in the dev extras makes more sense to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I've noticed with black, with is quite frustrating, is that it cannot be unpinned without causing other problems. Pipenv will refuse to install it as a "pre-release" without adding the additional flag. This long traceback can be a bit off-putting for some users. Though easily resolved it could also break any scripts that use Pipenv and do not include this flag.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I was able to confirm.

Additional information:

I'm interested if it's feasible to remove black as a minimal dependency. It seems like we could provide it as an extra in one way or another

colorama = "*"
packaging = "*"
requirementslib = "*"
vistir = "*"
autopep8 = "*"
six = "*"
typing = "*"
chardet = "*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where you able to check if any of these packages may have been pinned for a reason?


[scripts]
# use this to sync this pipfile to setup.py, explained in CONTRIBUTING.md
Expand Down
848 changes: 460 additions & 388 deletions Pipfile.lock

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta:__legacy__"
34 changes: 18 additions & 16 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
],
# This field adds keywords for your project which will appear on the
# project page. What does your project relate to?
Expand Down Expand Up @@ -136,25 +137,26 @@
# https://packaging.python.org/en/latest/requirements.html
extras_require={
"dev": [
"pytest~=5.2; python_version >= '3.6'",
"pytest-mypy~=0.3; python_version >= '3.5'",
"pytest-cov~=2.7",
"pytest-datadir~=1.3",
"pytest-xdist~=1.29",
"tox~=3.14",
"autopep8~=1.4",
"pytest",
"pytest-mypy",
"pytest-cov",
"pytest-datadir",
"pytest-xdist",
"tox",
"autopep8",
]
},
install_requires=[
"pipfile~=0.0",
"black==19.10b0; python_version >= '3.6'",
"colorama~=0.4",
"packaging~=20.0",
"requirementslib~=1.5",
"vistir~=0.4",
"autopep8~=1.4; python_version < '3.6'",
"six~=1.12",
"typing~=3.7; python_version < '3.7'",
"pipfile",
"black==21.9b0; python_version >= '3.6'",
"colorama",
"packaging",
"requirementslib",
"vistir",
"autopep8",
"six",
"typing",
"chardet",
], # Optional
entry_points={
"console_scripts": ["pipenv-setup=pipenv_setup.main:cmd"]
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py27, py35, py36, py37, py38
envlist = py27, py35, py36, py37, py38, py39
skip_missing_interpreters=true

[testenv]
Expand Down