Skip to content

Commit

Permalink
[7.17] [Saved Objects] Provide stable sorting to the rows extracted f…
Browse files Browse the repository at this point in the history
…rom UI (elastic#187545) (elastic#188406)

Close elastic#179977

# Backport

This will backport the following commits from `main` to `7.17`:
- [[Saved Objects] Provide stable sorting to the rows extracted from UI
(elastic#187545)](elastic#187545)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-07-08T10:40:32Z","message":"[Saved
Objects] Provide stable sorting to the rows extracted from UI
(elastic#187545)\n\n## Summary\r\n\r\nPer the title\r\n\r\nClose
https://github.com/elastic/kibana/issues/179977","sha":"809a83df82ffe53102e7b1c4df1f6db120a054ea","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Core","Feature:Saved
Objects","release_note:skip","backport:skip","v8.16.0"],"number":187545,"url":"https://github.com/elastic/kibana/pull/187545","mergeCommit":{"message":"[Saved
Objects] Provide stable sorting to the rows extracted from UI
(elastic#187545)\n\n## Summary\r\n\r\nPer the title\r\n\r\nClose
https://github.com/elastic/kibana/issues/179977","sha":"809a83df82ffe53102e7b1c4df1f6db120a054ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187545","number":187545,"mergeCommit":{"message":"[Saved
Objects] Provide stable sorting to the rows extracted from UI
(elastic#187545)\n\n## Summary\r\n\r\nPer the title\r\n\r\nClose
https://github.com/elastic/kibana/issues/179977","sha":"809a83df82ffe53102e7b1c4df1f6db120a054ea"}}]}]
BACKPORT-->
  • Loading branch information
jloleysens authored and adelisle committed Aug 5, 2024
1 parent 8cea0c6 commit 314d9e6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,18 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const invalidRelations = await PageObjects.savedObjects.getInvalidRelations();

expect(invalidRelations).to.eql([
{
error: 'Saved object [visualization/missing-vis-ref] not found',
id: 'missing-vis-ref',
relationship: 'Child',
type: 'visualization',
},
{
error: 'Saved object [dashboard/missing-dashboard-ref] not found',
id: 'missing-dashboard-ref',
relationship: 'Child',
type: 'dashboard',
},
{
error: 'Saved object [visualization/missing-vis-ref] not found',
id: 'missing-vis-ref',
relationship: 'Child',
type: 'visualization',
},
]);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class SavedObjectsPageObject extends FtrService {
relationship: await relationship.getVisibleText(),
error: await error.getVisibleText(),
};
});
}).then((result) => result.sort((a, b) => a.id.localeCompare(b.id)));
}

async getTableSummary() {
Expand Down

0 comments on commit 314d9e6

Please sign in to comment.