Automate container build #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Feb 15, 2022
|
I added https://github.com/bdunne/container-amazon-smartstate/actions?query=branch%3Aadd_github_actions to the OP so we can see it go green before merging. |
bdunne
force-pushed
the
add_github_actions
branch
from
637036f
to
fa1ccdf
Compare
- It was failing to build due to an incompatible version of bundler - move common package install up to base image
Fryguy
reviewed
Feb 17, 2022
| echo "REGISTRY_USERNAME=${{ secrets.REGISTRY_USERNAME }}" >> $GITHUB_ENV | ||
| echo "REGISTRY_PASSWORD=${{ secrets.REGISTRY_PASSWORD }}" >> $GITHUB_ENV | ||
| - name: Run container build script | ||
| run: bin/build_container_image |
There was a problem hiding this comment.
Not for this PR, but I think it would be helpful to split the build into separate build and deploy steps. This way, from GHA, we can gate the deploy separate from the build, and it's less "magical" looking as to what's happening.
There was a problem hiding this comment.
👍🏻 That sounds like a good followup since it will apply to several repos
Fryguy
reviewed
Feb 17, 2022
Co-authored-by: Jason Frey <fryguy9@gmail.com>
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
May 9, 2022
Automate container build (cherry picked from commit 4692b75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bdunne/container-amazon-smartstate/actions?query=branch%3Aadd_github_actions