Parse config file on NetworkInterface#reload #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Aug 5, 2024
| @@ -12,6 +12,13 @@ class NetworkInterfaceRH < NetworkInterface | |||
| def initialize(interface) | |||
| @interface_file = self.class.path_to_interface_config_file(interface) | |||
| super | |||
There was a problem hiding this comment.
NOTE the base class initialize calls reload so we don't need to super then parse_conf here.
agrare
force-pushed
the
network_interface_parse_config_file_on_reload
branch
from
8051f20
to
a91b888
Compare
|
Checked commit agrare@a91b888 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Aug 5, 2024
|
Yeah this makes more sense. 👍 |
bdunne
added a commit
that referenced
this pull request
Aug 13, 2024
Breaking Changes: - Use --json for ip command output #251 Added: - Add network interface loopback #254 - Add LinuxAdmin::NetworkInterface.list #249 Changed: - Parse config file on NetworkInterface#reload #253 Test: - Use ruby 3.1 and rails 7 for code coverage #250 - Fix rubocop warnings in NetworkInterface Spec #252 - Update paambaati/codeclimate-action action to v8 #248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't checked other callers of reload to see if this makes sense so I'd like your opinions @bdunne / @Fryguy but I was looking at https://github.com/ManageIQ/manageiq-appliance_console/blob/master/bin/appliance_console#L92-L93 and the
.reloadthen.parse_conf if respond_to?(:parse_conf)looked like it could be improved by moving this logic into the NetworkInterfaceRh subclass.