Move gem name loader to proper namespaced location. #208
Conversation
jrafanie
force-pushed
the
zeitwerk_gem_name_loader
branch
from
08b3826
to
d2bb0bd
Compare
|
I think the proper solution is to create This is the pattern I tend to see in gems. |
|
@kbrock yeah, I understand that is/was the standard for non-rails stuff but zeitwerk is adopting the fairly new (maybe last several years) standard of lib/manageiq/appliance_console.rb, see: https://guides.rubygems.org/name-your-gem/ Checkout https://github.com/fxn/zeitwerk/issues 138 for more background. Basically, zeitwerk is expecting files to define the constants based on their name and these "gem name.rb" loader files in lib fail this test. I'd like to find a way to get zeitwerk to work with them without needing to continually tell zeitwerk to ignore them but for now, this is the easiest way. Basically, unless we expect requires to use the manageiq-appliance_console format, we can safely let bundler do the require as it will try the hyphen form, and if that doesn't exsit, it will use the manageiq/appliance_console form of require. |
|
I kicked but I think https://github.com/ManageIQ/manageiq-appliance_console/blob/master/Gemfile having 2 |
|
searched all the code. Looks like the only references to |
|
kicking to start the build again. |
jrafanie
force-pushed
the
zeitwerk_gem_name_loader
branch
from
d2bb0bd
to
2fcbbf4
Compare
jrafanie
force-pushed
the
zeitwerk_gem_name_loader
branch
from
2fcbbf4
to
e35bfbb
Compare
|
Checked commit jrafanie@e35bfbb with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Move gem name loader to proper namespaced location. (cherry picked from commit befefc2)
Fixed - Fix sporadic test failure [#204] - Remove MIQ specific gem source [#209] - Double escape @ in realm to avoid shell interpretation [#211] - Move gem name loader to proper namespaced location [#208] - Separate kerberos from service principal name and use correctly [#215] - Add manageiq user to allowed_uids for sssd [#220] - Remove warning about using pg_dump [#221] - Fix specs where AwesomeSpawn private interface changed [#224] - Change the Name of the CA from something to ApplianceCA [#228] - Fix YAML.load_file failing on aliases [#234] Added - Make backward compatible changes to work with repmgr13 - version 5.2.1 [#192] - Support Ruby 3.0 [#206] - Support Ruby 3.1 [#227] - Allow rails 7 gems in gemspec [#226] Changed - Update to Highline 2.1.0 [#201] - Clean up test output (highline and stdout messages) [#210] Removed - Drop Ruby 2.7 [#223]
Move gem name loader to proper namespaced location.