Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix to reusable workflow #85

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 8, 2022

Workaround the limit of 20 other workflows referenced in a single github workflow, https://github.saobby.my.eu.orgmunity/t/too-many-workflows-are-referenced-limit-is-20/211391

Credit to https://github.saobby.my.eu.orgmunity/t/reusable-workflow-with-strategy-matrix/205676/6 for the syntax of adding a matrix in to a reusable workflow

@@ -19,6 +19,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
test-repo: ${{ fromJson(inputs.test-repo) }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE arrays are not supported (only string, boolean, number) so you have to pass a string containing a json array then parse that on this side

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare agrare force-pushed the use_matrix_cross_repo_workflow branch from 6f9544c to 94661db Compare February 8, 2022 22:13
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a failure or something that can show that this change is working? (i.e.: red -> green)

@agrare
Copy link
Member Author

agrare commented Feb 9, 2022

@agrare
Copy link
Member Author

agrare commented Feb 9, 2022

We have 23 provider repos and I was trying /providers test and hit that error

@Fryguy Fryguy merged commit 4c94a43 into ManageIQ:master Feb 9, 2022
@agrare agrare deleted the use_matrix_cross_repo_workflow branch February 9, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants