Minor updates to Configuation and Initial Login includes #1805
Conversation
|
Hey @qahmed1998 could you add a more descriptive title and description about what this change is doing? |
|
@miq-bot add_labels radjabov/yes? |
_includes/initial-login-changepw.md
Outdated
| @@ -1,8 +1,7 @@ | |||
| Change your password to ensure more private and secure access to | |||
| {{ site.data.product.title_short }}. | |||
|
|
|||
| 1. Browse to the URL for the login screen. (<https://xx.xx.xx.xx> on | |||
| the virtual machine instance) | |||
| 1. Browse to the URL for the login screen. | |||
There was a problem hiding this comment.
@Fryguy how can we improve this line?
There was a problem hiding this comment.
The parenthesis shows an example, so maybe adding an e.g.? I'm not sure what was wrong with it originally.
There was a problem hiding this comment.
Yeah I think the original was okay, maybe something to say "get the ipaddress or hostname from the VM"
There was a problem hiding this comment.
I meant like in terms of navigation, how does a user get the URL?
There was a problem hiding this comment.
It is going to be different on every platform (vmware, amazon, google, etc...) but all of them will show you the IP address and/or dns name of the VM in some way.
There was a problem hiding this comment.
Hmm for example this doc is for GCP, I am still not sure how exactly user will get the URL for the login screen. We should mention it in terms of how to get that URL.
There was a problem hiding this comment.
This doc isn't for GCP, it is included into all of the "installing_on_*" docs,
$ grep -r initial-login-changepw
installing_on_scvmm/index.md:{% include initial-login-changepw.md %}
installing_on_vmware_vsphere/index.md:{% include initial-login-changepw.md %}
installing_on_microsoft_azure/index.md:{% include initial-login-changepw.md %}
installing_on_google_compute_engine/index.md:{% include initial-login-changepw.md %}
installing_on_red_hat_virtualization/index.md:{% include initial-login-changepw.md %}
grep: .git/index: binary file matches
installing_on_red_hat_enterprise_linux_openstack_platform/index.md:{% include initial-login-changepw.md %}
Which was the point of my comment 👇 #1805 (comment)
There was a problem hiding this comment.
IMO I think it is reasonable to assume that a user will know how to get the IP address of the VM that they just deployed on whatever platform they're using.
qahmed1998
changed the title
|
@qahmed1998 FYI it looks like these changes are all to includes which are in multiple topics not just google compute engine |
|
Checked commits qahmed1998/manageiq-documentation@570f458~...41a0b02 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
changed the title
|
Backported to |
Minor updates to Installing on Google Compute Engine topic (cherry picked from commit c64feef)
This PR just cleanups up some minor issues in "Installing on Google Compute Engine topic".