-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump fog-openstack to v0.3 #386
Conversation
Checked commit https://github.com/gildub/manageiq-gems-pending/commit/d47684e1cadce6c6a077538d392c388eec700c57 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@jerryk55 this won't cause any issues with the backup work, right? |
@gildub why are we doing this? Is there a particular bug or feature what you're adding? Should this be backported to the Hammer release? |
@miq-bot add_label hammer/yes |
@carbonin, although I've added the flag for hammer backport. |
What do you mean by that? Hammer is not GA yet, so this would be in the GA release, not a "sub release" |
@carbonin, technically we could go for Hammer GA if not too close otherwise sub-release. |
Okay, then this shouldn't be |
@carbonin, yeap, thanks. |
@carbonin, Well actually we still have time for Hammer GA because that's would be really a plus. |
@agrare what do you think about this (and by extension ManageIQ/manageiq-providers-openstack#334) going back to hammer? I would rather not backport this version bump if we aren't going to end up using it. |
@gildub I'll merge this to master for now and continue the conversation about backport. |
@carbonin we had planned on the new version of fog only going into ivanchuk and not hammer. |
@gildub should this have been WIP until the VCRs on ManageIQ/manageiq-providers-openstack#334 were ready? |
Revert "Merge pull request #386 from gildub/bump_fog-openstack"
@agrare, sorry I missed your last comment! The VCRs were ready or on their way, timing was the essence. I believe that having several repos depending on fog-openstack should be avoided and more likely gem-pending is the temporary lasting too long. |
@gildub Ah okay the last few comments sounded like Sam was going to record them for you |
@agrare, @mansam, the bump for hammer (for the record) is ManageIQ/manageiq-providers-openstack#387. Thanks |
This is needed because other dependencies on fog-core.
For more details please see ManageIQ/manageiq#17997