Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump fog-openstack to v0.3 #386

Merged
merged 1 commit into from
Oct 26, 2018
Merged

bump fog-openstack to v0.3 #386

merged 1 commit into from
Oct 26, 2018

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Oct 23, 2018

This is needed because other dependencies on fog-core.
For more details please see ManageIQ/manageiq#17997

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2018

Checked commit https://github.com/gildub/manageiq-gems-pending/commit/d47684e1cadce6c6a077538d392c388eec700c57 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@carbonin
Copy link
Member

@jerryk55 this won't cause any issues with the backup work, right?

@carbonin carbonin self-assigned this Oct 23, 2018
@carbonin
Copy link
Member

@gildub why are we doing this? Is there a particular bug or feature what you're adding? Should this be backported to the Hammer release?

@gildub
Copy link
Contributor Author

gildub commented Oct 24, 2018

@miq-bot add_label hammer/yes

@gildub
Copy link
Contributor Author

gildub commented Oct 24, 2018

@carbonin, although fog-openstack has been added recently to manageiq-gems-pending it is also heavily used by manageiq-providers-openstack. V0.3.x contains massive refactor and we're targeting next sub release.

I've added the flag for hammer backport.

@carbonin
Copy link
Member

next sub release

What do you mean by that? Hammer is not GA yet, so this would be in the GA release, not a "sub release"

@gildub
Copy link
Contributor Author

gildub commented Oct 25, 2018

@carbonin, technically we could go for Hammer GA if not too close otherwise sub-release.

@carbonin
Copy link
Member

Okay, then this shouldn't be hammer/yes at this point that means that it would go into GA

@gildub
Copy link
Contributor Author

gildub commented Oct 26, 2018

@carbonin, yeap, thanks.

@gildub
Copy link
Contributor Author

gildub commented Oct 26, 2018

@carbonin, Well actually we still have time for Hammer GA because that's would be really a plus.
Besides hammer, this is a blocker for ManageIQ/manageiq-providers-openstack#334. Unless you see any reason not to, do you mind merging, please?

@carbonin
Copy link
Member

@agrare what do you think about this (and by extension ManageIQ/manageiq-providers-openstack#334) going back to hammer?

I would rather not backport this version bump if we aren't going to end up using it.

@carbonin
Copy link
Member

@gildub I'll merge this to master for now and continue the conversation about backport.

@carbonin carbonin merged commit 1bffaf4 into ManageIQ:master Oct 26, 2018
@agrare
Copy link
Member

agrare commented Oct 26, 2018

@carbonin we had planned on the new version of fog only going into ivanchuk and not hammer.

@agrare
Copy link
Member

agrare commented Oct 26, 2018

@gildub should this have been WIP until the VCRs on ManageIQ/manageiq-providers-openstack#334 were ready?

agrare added a commit to agrare/manageiq-gems-pending that referenced this pull request Oct 26, 2018
carbonin added a commit that referenced this pull request Oct 26, 2018
Revert "Merge pull request #386 from gildub/bump_fog-openstack"
@gildub gildub deleted the bump_fog-openstack branch October 29, 2018 07:09
@gildub
Copy link
Contributor Author

gildub commented Oct 30, 2018

@agrare, sorry I missed your last comment! The VCRs were ready or on their way, timing was the essence. I believe that having several repos depending on fog-openstack should be avoided and more likely gem-pending is the temporary lasting too long.

@agrare
Copy link
Member

agrare commented Oct 30, 2018

@gildub Ah okay the last few comments sounded like Sam was going to record them for you

@gildub
Copy link
Contributor Author

gildub commented Nov 2, 2018

@agrare, @mansam, the bump for hammer (for the record) is ManageIQ/manageiq-providers-openstack#387. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants