Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions #812

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Switch to GitHub Actions #812

merged 1 commit into from
Feb 10, 2022

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Feb 9, 2022

No description provided.

@bdunne bdunne added the test label Feb 9, 2022
Fryguy
Fryguy reviewed Feb 9, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated
go-version: '1.14'
- name: Run tests
run:
- travis_wait curl -L https://github.com/operator-framework/operator-sdk/releases/download/v0.18.2/operator-sdk-v0.18.2-$(uname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis_wait is not here

Copy link
Member

@Fryguy Fryguy Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we move this into a bin/before_install for consistency with other repos? before_install should be a shell script that checks for CI and installs any system packages and whatnot (Example: https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/bin/before_install). before_install should be before the Set up Ruby step (and so should be a pure shell script (Example: https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/.github/workflows/ci.yaml#L30-L31)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the bin/before_install script as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunne ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chessbyte chessbyte mentioned this pull request Feb 9, 2022
Closed
@bdunne bdunne force-pushed the switch_to_gha branch 2 times, most recently from f556da1 to 1bb87df Compare February 10, 2022 18:35
@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2022

Checked commit bdunne@f1a9e60 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@chessbyte
Copy link
Member

@Fryguy seems like this ready for review

@Fryguy Fryguy merged commit 7b29079 into ManageIQ:master Feb 10, 2022
@Fryguy Fryguy self-assigned this Feb 10, 2022
@bdunne bdunne deleted the switch_to_gha branch February 11, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy left review comments

@chessbyte chessbyte chessbyte left review comments

Assignees

@Fryguy Fryguy

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @chessbyte @Fryguy