Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to receive datastore by name or by id #37

Closed

Conversation

masayag
Copy link
Contributor

@masayag masayag commented May 16, 2017

Datastores on the same setup may have the same name. In order to add a
disk on a specific datastore, it is better to use the datastore id.

https://bugzilla.redhat.com/show_bug.cgi?id=1450952
https://bugzilla.redhat.com/show_bug.cgi?id=1427498

@masayag masayag force-pushed the accept_datastore_id_when_adding_disk branch 3 times, most recently from bf96c5a to e154228 Compare May 16, 2017 13:27
agrare pushed a commit to agrare/manageiq-providers-ovirt that referenced this pull request May 16, 2017
…_fixed_ip_per_eni

Fix collection of secordary fixed ip per eni
@masayag masayag force-pushed the accept_datastore_id_when_adding_disk branch 2 times, most recently from cff61a1 to 5763a16 Compare May 17, 2017 12:57
@masayag
Copy link
Contributor Author

masayag commented May 17, 2017

This PR depends on ManageIQ/manageiq#15101

@masayag
Copy link
Contributor Author

masayag commented May 17, 2017

@masayag
Copy link
Contributor Author

masayag commented May 18, 2017

@masayag
Copy link
Contributor Author

masayag commented May 18, 2017

@borod108 this PR depends on ManageIQ/manageiq#15101 but could be review at the meanwhile.

context "when storage exists" do
let(:storage) { FactoryGirl.create(:storage, :name => storage_name, :id => storage_id) }

it "searches for a storage by its ID" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the "searcher" to "finds" here and in the next examples because when I read this I thought you will have something like expect(Storage).to receive(:find)

@masayag masayag force-pushed the accept_datastore_id_when_adding_disk branch from 5763a16 to c00b78e Compare May 18, 2017 11:21
Datastores on the same setup may have the same name. In order to add a
disk on a specific datastore, it is better to use the datastore id.

https://bugzilla.redhat.com/show_bug.cgi?id=1450952
https://bugzilla.redhat.com/show_bug.cgi?id=1427498
@masayag masayag force-pushed the accept_datastore_id_when_adding_disk branch from c00b78e to a9c2c12 Compare May 18, 2017 12:09
@miq-bot
Copy link
Member

miq-bot commented May 18, 2017

Checked commit masayag@a9c2c12 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@masayag masayag closed this May 29, 2017
@masayag masayag deleted the accept_datastore_id_when_adding_disk branch May 29, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants