-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Properly update network hash when the first array element is nil
Refactor and add tests for normalize_network_adapter_settings https://bugzilla.redhat.com/show_bug.cgi?id=1508069#c4
- Loading branch information
1 parent
68f09bf
commit 0566401
Showing
2 changed files
with
81 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
spec/models/manageiq/providers/vmware/infra_manager/provision/configuration/network_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
describe ManageIQ::Providers::Vmware::InfraManager::Provision::Configuration::Network do | ||
describe '#normalize_network_adapter_settings' do | ||
let(:miq_provision) { FactoryGirl.build(:miq_provision_vmware, :options => options) } | ||
|
||
shared_examples_for 'normalize_network_adapter_settings' do | ||
it 'updates network options' do | ||
miq_provision.normalize_network_adapter_settings | ||
|
||
expect(miq_provision.options).to include(network_options) | ||
end | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:vlan => %w(network network), :mac_address => 'aa:bb:cc:dd:ee:ff'} } | ||
let(:network_options) { {:networks=>[{:network => 'network', :mac_address => 'aa:bb:cc:dd:ee:ff'}]} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:vlan => %w(dvs_network network)} } | ||
let(:network_options) { {:networks => [{:network => 'network', :is_dvs => true}]} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:vlan => %w(network network), :networks => []} } | ||
let(:network_options) { {:networks=>[{:network=>'network'}]} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:vlan => %w(network network), :networks => [nil]} } | ||
let(:network_options) { {:networks=>[{:network=>'network'}]} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:networks => [{:network => 'network'}]} } | ||
let(:network_options) { {:vlan => %w(network network)} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
|
||
context 'adds default adapter into networks hash' do | ||
let(:options) { {:networks => [{:network => 'network', :is_dvs => true}]} } | ||
let(:network_options) { {:vlan => %w(dvs_network network)} } | ||
|
||
it_behaves_like 'normalize_network_adapter_settings' | ||
end | ||
end | ||
end |