Skip to content

Commit

Permalink
Collect IP and MAC address properly
Browse files Browse the repository at this point in the history
With this commit we fix a bug that prevented IP address and MAC
from being collected properly. NetworkManager's refresh parser has
been updated to be more robust and effective and some complex VCR unit
tests were added where we ensure that things will work on a more
advanced networking setup as well. Performance optimization was achieved
like this:

BEFORE: first all vdcs were fetched, then all vapps per vdc, then
all vms per vapp. Then finally the network data was fetched from the
VM, where only the most basic data was present (e.g. MAC was missing).

NOW: we load VMs from VMDB (inventoried by cloud provider) and then
invoke a single API call per VM to fetch networking data for it.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
  • Loading branch information
miha-plesko committed Jan 23, 2018
1 parent d417fee commit a703ff3
Show file tree
Hide file tree
Showing 7 changed files with 11,001 additions and 14,468 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
class ManageIQ::Providers::Vmware::NetworkManager::FloatingIp < ::FloatingIp
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
class ManageIQ::Providers::Vmware::NetworkManager::NetworkRouter < ::NetworkRouter
end
Loading

0 comments on commit a703ff3

Please sign in to comment.