Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup MiqFaultTolerantVim #520

Closed
3 tasks done
agrare opened this issue Jan 27, 2020 · 2 comments
Closed
3 tasks done

Cleanup MiqFaultTolerantVim #520

agrare opened this issue Jan 27, 2020 · 2 comments
Assignees
@agrare
Labels
cleanup help wanted

Comments

@agrare
Copy link
Member

agrare commented Jan 27, 2020 •
edited
Loading

The MiqFaultTolerantVim class existed to handle issues connecting to the broker without failing the method that was being executed. These issues included EMFILE issues when too many sockets were opened and the broker restarting and getting a new DRb port number that had to be discovered.

These are no longer relevant so any code calling MiqFaultTolerantVim can be replaced with MiqVim.

Once these are removed then the MiqFaultTolerantVim class in the VMwareWebService gem can also be removed.

#484
ManageIQ/manageiq-smartstate#112
@agrare agrare mentioned this issue Feb 10, 2020
Merged
@agrare agrare mentioned this issue Feb 24, 2020
Merged
@chessbyte
Copy link
Member

@agrare this seems completed now

@agrare
Copy link
Member Author

agrare commented Mar 2, 2020

@chessbyte 👍 yes you're right, was waiting for a smartstate release to be cut with that PR and there is one now

@agrare agrare closed this as completed Mar 2, 2020
@agrare agrare self-assigned this Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrare agrare

Labels
cleanup help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chessbyte @agrare