Properly update network hash when the first array element is nil #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
force-pushed
the
normalize_network_adapter
branch
from
7818d14
to
0566401
Compare
Refactor and add tests for normalize_network_adapter_settings https://bugzilla.redhat.com/show_bug.cgi?id=1508069
gmcculloug
force-pushed
the
normalize_network_adapter
branch
from
0566401
to
8b196f6
Compare
|
Checked commit gmcculloug@8b196f6 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
Properly update network hash when the first array element is nil (cherry picked from commit 9d93a0d) https://bugzilla.redhat.com/show_bug.cgi?id=1511502
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
Properly update network hash when the first array element is nil (cherry picked from commit 9d93a0d) https://bugzilla.redhat.com/show_bug.cgi?id=1511501
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Spec test for excluding orphaned vms from quota.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
set_network_adapter(idx, config_hash)from automate it is common to set additional adapters beyond what was selected from the provisioning dialogs.If a caller passes
set_network_adapter(1, <config_hash>)the:networkoption hash will contain anilin the first array element. For example the previous call would create the following array:options[:networks] = [nil, <config_hash>]The first array element is meant to be populated with the dialog network selection, but was instead causing an
undefined method '[]' for nil:NilClass)]error.With this change the code ensures that
options[:networks]is an array and populates the first element with the dialog network settings if it is blank.Refactor and add tests for normalize_network_adapter_settings
https://bugzilla.redhat.com/show_bug.cgi?id=1508069