Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed supports_snapshots? methods defined independently without using supportsFeatureMixin plugin #14

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

gauravaradhye
Copy link
Contributor

Removed instance where supports_snapshots? method was defined without using supportsFeatureMixin.

@agrare agrare requested a review from durandom February 16, 2017 17:56
@agrare
Copy link
Member

agrare commented Feb 16, 2017

LGTM, @durandom ?

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 straight forward, please merge

@agrare agrare merged commit f6720e9 into ManageIQ:master Feb 16, 2017
@agrare
Copy link
Member

agrare commented Feb 16, 2017

Thanks @gauravaradhye !

@agrare agrare self-assigned this Jun 5, 2018
@agrare agrare added this to the Sprint 55 Ending Feb 27, 2017 milestone Jun 5, 2018
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants