Use utility function vm_powered_on? instead manual comparison #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miha-plesko
changed the title
miha-plesko
force-pushed
the
vm-delete-followup
branch
from
c0e4ffe
to
5b89c35
Compare
With this commit we replace manual comparison of status with utility function. The logic is a bit more bullet-proof now since we now only prevent VM delete when VM is "ON" while we originally only allowed delete when VM was "OFF". So effectively we now allow VM delete even if status is e.g. "unknown" which I think should succeed. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
vm-delete-followup
branch
from
5b89c35
to
ffe13b2
Compare
|
Checked commit miha-plesko@ffe13b2 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Use utility function vm_powered_on? instead manual comparison (cherry picked from commit 15f83b5) https://bugzilla.redhat.com/show_bug.cgi?id=1552683
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…callback Nuage events callbacks for targeted refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we replace manual comparison of status with utility function. The logic is a bit more bullet-proof now since we now only prevent VM delete when VM is "ON" while we originally only allowed delete when VM was "OFF". So effectively we now allow VM delete even if status is e.g. "unknown" which I think should succeed.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1550841
@miq-bot assign @agrare
@miq-bot add_label enhancement,gaprindashvili/yes
Followup for #184