Add support for vCloud console access via WebMKS #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2018
miha-plesko
force-pushed
the
console-access
branch
from
4b7cfaa
to
5c3f143
Compare
|
I've added unit tests, @skateman looking forward for your comments also on this one. |
With this commit we provide code needed for VMware vCloud Director's (i.e. CloudManager) console access to work. The code is similar to that of InfraManger, but with some important differences: * WebMKS SDK requires additional information (vmx location) * WebMKS SDK must know it's vCloud's VM to use uint8utf8 protocol (instead binary) * websocket proxy must connect to differently formed URL (port is part of URL, while actual port is always 443) Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
console-access
branch
from
5c3f143
to
048cff6
Compare
|
@agrare both depending PRs have been merged (UI even a bit too soon, because I happend to forget to put the pending/core label) so I kindly ping you for this one. It's more or less copy-paste from Infra, only a lot simpler bcs WebMKS only. |
|
Checked commit miha-plesko@048cff6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
added a commit
that referenced
this pull request
Apr 3, 2018
Add support for vCloud console access via WebMKS
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2018
Add support for vCloud console access via WebMKS (cherry picked from commit db12e68) https://bugzilla.redhat.com/show_bug.cgi?id=1563364
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Use supports_vm_import? instead of validate_import_vm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we provide code needed for VMware vCloud Director's (i.e. CloudManager) console access to work. The code is similar to that of InfraManger, but with some important differences:
actual port is always 443)
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1560517
@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare
Related PRs:
ManageIQ/manageiq-ui-classic#3679 (merged)
ManageIQ/manageiq#17200 (merged)
/cc @bmclaughlin @gberginc