Add supports revert to snapshot #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit revert snapshot is enabled. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567760 Signed-off-by: sasoc <saso.cvitkovic@gmail.com>
|
cc @miha-plesko |
miha-plesko
approved these changes
Apr 16, 2018
|
Checked commit sasoc@a951bf8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Hi @agrare , I kindly ask you to merge this tiny PR. Testing the CFME 5.9.2.2 appliance we noticed "Revert from Snapshot" option is somehow disabled. It turned out that it's because we've added the supports_not :remove_snapshotin some other commit which disabled BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1567760 @miq-bot add_label bug,gaprindashvili/yes |
gtanzillo
approved these changes
Apr 16, 2018
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2018
Add supports revert to snapshot (cherry picked from commit 0be2f13) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567962
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Check for both owner email and requester email for user quota.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit revert snapshot is enabled.
Revert to snapshot is supported only if delete snapshot is supported. At first delete snapshot was enabled, but after revert to snapshot was merged I implemented #191 (review). Since I did not know revert relied on delete snapshot and there was no test to check, if revert to snapshot is supported, mistake went through unnoticed.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567760