Validate deviceMode on a VirtualDisk Backing before reconfigure #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check settings on a virtual device in a device change set before submitting the ReconfigVM_Task. This includes ensuring that the deviceMode is correct for the given backing type. https://bugzilla.redhat.com/show_bug.cgi?id=1430374
agrare
force-pushed
the
bz_1430374_validate_reconfig_device_mode
branch
from
c815421
to
b642412
Compare
|
cc @lfu |
lfu
reviewed
Mar 14, 2017
| @@ -162,6 +162,25 @@ def disk_mode(dependent, persistent) | |||
| end | |||
| end | |||
|
|
|||
| def validate_device_backing(backing) | |||
| case backing.xsiType | |||
| when 'VirtualDiskFlatVer2BackingInfo' | |||
There was a problem hiding this comment.
@agrare
I'm confused with VirtualDiskFlatVer2BackingOption and VirtualDiskFlatVer2BackingInfo.
Looks like the valid modes defined here is for VirtualDiskFlatVer2BackingOption.
According to the ref, valid modes for VirtualDiskFlatVer2BackingInfo are:
The disk persistence mode. Valid modes are:
persistent
independent_persistent
independent_nonpersistent
nonpersistent
undoable
append
There was a problem hiding this comment.
So they don't do a great job of documenting what modes are supported or not.
Those are all valid modes and the reconfigure will succeed, but if you actually use some of the modes the VM won't even power-on.
Those three modes are the ones that the vSphere client will let you select for the disk mode.
|
👍 LGTM |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…chine Initial commit for new generic service state machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user has the option of setting the disk mode when adding a disk during reconfigure, the possible options provided by VMware are: append, independent_nonpersistent, independent_persistent, nonpersistent, persistent, undoable [ref]
However not all of these options are valid for all backing type. Specifically the backing type that we use for new disks (
VirtualDiskFlatVer2Backing) only supportspersistent,independnet_persistent, andindependent_nonpersistent[ref]This will validate before submitting the
ReconfigVM_Taskthat a supported diskMode was selected by the user.This should be followed up by a UI change to only display valid options to the user, currently it is possible for the user to select persistent, nonpersistent, independent_persistent, and independent_nonpersistent.
https://bugzilla.redhat.com/show_bug.cgi?id=1430374