Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec test for deleting a VM #255

Merged
merged 4 commits into from
May 10, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented May 9, 2018

Fix a few issues related to deleting inventory objects including cache deletion, manager_uuids/targeted_scope, and disconnecting vms_and_templates.

@agrare agrare force-pushed the add_spec_for_deleting_a_vm branch from e2e5eef to 14a2eec Compare May 9, 2018 16:04
@agrare agrare force-pushed the add_spec_for_deleting_a_vm branch from 14a2eec to 21abd26 Compare May 9, 2018 16:24
@miq-bot
Copy link
Member

miq-bot commented May 9, 2018

Checked commits agrare/manageiq-providers-vmware@284d4fd~...21abd26 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Ladas Ladas merged commit f7192d8 into ManageIQ:master May 10, 2018
@Ladas Ladas added this to the Sprint 86 Ending May 21, 2018 milestone May 10, 2018
@Ladas Ladas self-assigned this May 10, 2018
@agrare agrare deleted the add_spec_for_deleting_a_vm branch May 25, 2018 15:08
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants