Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the lan from a guest_device #266

Merged
merged 1 commit into from
May 22, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented May 18, 2018

Parse the lan for a guest device for standard VM networks. Since the lan depends on the switch id this has to be looked up from the cache based on the host that the VM is on.

@agrare agrare force-pushed the parse_vm_network_guest_devices branch 2 times, most recently from 06e4bb5 to 1f5f602 Compare May 21, 2018 12:15
@agrare agrare force-pushed the parse_vm_network_guest_devices branch from 1f5f602 to 9372218 Compare May 22, 2018 15:43
@miq-bot
Copy link
Member

miq-bot commented May 22, 2018

Checked commit agrare@9372218 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

app/models/manageiq/providers/vmware/infra_manager/inventory/parser/virtual_machine.rb

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ladas Ladas merged commit 961d960 into ManageIQ:master May 22, 2018
@Ladas Ladas added this to the Sprint 87 Ending Jun 4, 2018 milestone May 22, 2018
@agrare agrare deleted the parse_vm_network_guest_devices branch May 22, 2018 16:28
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…irement_status_spec

Add namespace and task status message to vm retirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants