Fixes ProvisionWorkflow#available_vlans_and_hosts #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `super` form of this method returns `nil` for hosts, the `.map(&:id)` call would no work properly. In previous forms, `hosts` had `to_miq_a`, which will effectively run an `Array.wrap` around the object. I figured moving away from specialty code for this was a better option moving forward, so I skipped that an opted for an `unless` check instead.
|
Checked commit NickLaMuro@c0a5a9e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Thanks @NickLaMuro |
|
Sorry for breaking it in the first place 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
superform of this method returnsnilfor hosts, the.map(&:id)call would no work properly.In previous forms,
hostshadto_miq_a, which will effectively run anArray.wraparound the object. I figured moving away from specialty code for this was a better option moving forward, so I skipped that an opted for anunlesscheck instead.The tests added in this PR mimic what is done in
manageiq-ui-classic, which was the original "canary in the coal mine" that exposed this error.Links