Add ems_ref_obj to streaming refresh parser #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out this fixes provisioning as well, I thought we weren't getting hardware back because it wasn't cached but really it was because we were failing to get a miqVimVm object because the ems_ref_obj was nil. |
|
Checked commit agrare@d2c7a6e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ems_ref_obj to perform actions using the VimBroker because it requires the object's class name for the references when building the XML spec.
Example: https://github.com/ManageIQ/vmware_web_service/blob/master/lib/VMwareWebService/VimService.rb#L175 using the vimType and https://github.com/ManageIQ/vmware_web_service/blob/master/lib/VMwareWebService/VimService.rb#L182 using the xsiType