Set the ems last_refresh error/time attributes #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a refresh finishes set the last_refresh_error and last_refresh_time attributes on the ems.
agrare
force-pushed
the
update_ems_last_refresh
branch
from
8aa6dfc
to
3b9118b
Compare
|
Checked commit agrare@3b9118b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/vmware/infra_manager/inventory/collector.rb
app/models/manageiq/providers/vmware/infra_manager/inventory/saver.rb
|
Ladas
reviewed
Jul 11, 2018
| @@ -84,5 +84,12 @@ def dequeue | |||
|
|
|||
| def save_inventory(persister) | |||
| persister.persist! | |||
| update_ems_refresh_stats(persister.manager) | |||
| rescue => err | |||
| update_ems_refresh_stats(persister.manager, :error => err.to_s) | |||
There was a problem hiding this comment.
should we log the backtrace here?
There was a problem hiding this comment.
Good catch I'll push a follow-up PR
Ladas
approved these changes
Jul 11, 2018
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…rovisionrequest_denied_approver_href Fix servicetemplateprovisionrequest_denied approver_href method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a refresh finishes set the last_refresh_error and
last_refresh_time attributes on the ems.