Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization fix #308

Conversation

pkomanek
Copy link
Contributor

@pkomanek pkomanek commented Aug 1, 2018

Fix for broken customization(sysprep) during vm provisioning.

Description: Customizing Windows template with sysprep during provision didn't apply any changes to VM.

Steps to Reproduce:
1.Initiate VM provision with sysprep customization
2.on Customize tab/Sysprep Answer File upload unattended answer xml file(or select one of Customization Templates created on the Vmware provider side)

https://bugzilla.redhat.com/show_bug.cgi?id=1565763

@miq-bot miq-bot added the wip label Aug 1, 2018
@pkomanek pkomanek force-pushed the broken_customization_during_vm_provisioning_fix branch 3 times, most recently from acf9edd to 4e390e0 Compare August 2, 2018 10:18
@agrare agrare self-assigned this Aug 2, 2018
@pkomanek pkomanek force-pushed the broken_customization_during_vm_provisioning_fix branch from 4e390e0 to 00adb1e Compare August 3, 2018 11:03
@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2018

Checked commits pkomanek/manageiq-providers-vmware@6468dff~...00adb1e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@pkomanek pkomanek changed the title [WIP] Customization fix Customization fix Aug 3, 2018
@miq-bot miq-bot removed the wip label Aug 3, 2018
@agrare agrare added the bug label Aug 3, 2018
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice test @pkomanek !

@agrare agrare merged commit 00adb1e into ManageIQ:master Aug 3, 2018
agrare added a commit that referenced this pull request Aug 3, 2018
@agrare agrare added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 3, 2018
@pkomanek pkomanek deleted the broken_customization_during_vm_provisioning_fix branch August 6, 2018 09:37
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…ured_system

Email instances for /Infrastructure/Configured_System provisioning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants