Add plugin display name #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mzazrivec@7d67082 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
reviewed
Aug 23, 2018
| @@ -3,6 +3,10 @@ module Providers | |||
| module Vmware | |||
| class Engine < ::Rails::Engine | |||
| isolate_namespace ManageIQ::Providers::Vmware | |||
|
|
|||
| def self.plugin_name | |||
| _('VMware Provider') | |||
There was a problem hiding this comment.
Hm there are technically two providers in this plugin
There was a problem hiding this comment.
This string is mainly to be presented in the about dialog in classic UI, so I guess we don't have to be super-precise about it. Though if there's a better way to name it, I'm open to suggestions.
agrare
approved these changes
Aug 23, 2018
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Fix System/CommonMethods/MiqAe directory name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ManageIQ/manageiq-ui-classic#4496 for primary motivation.