Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin display name #312

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Add plugin display name #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/manageiq/providers/vmware/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ module Providers
module Vmware
class Engine < ::Rails::Engine
isolate_namespace ManageIQ::Providers::Vmware

def self.plugin_name
_('VMware Provider')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm there are technically two providers in this plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is mainly to be presented in the about dialog in classic UI, so I guess we don't have to be super-precise about it. Though if there's a better way to name it, I'm open to suggestions.

end
end
end
end
Expand Down