Shift fog-vcloud-director version to 0.3.0 #321
Conversation
manageiq-providers-vmware.gemspec
Outdated
| @@ -13,7 +13,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.files = Dir["{app,config,lib}/**/*"] | |||
|
|
|||
| s.add_dependency("fog-vcloud-director", ["~> 0.2.2"]) | |||
| s.add_dependency("fog-vcloud-director", ["~> 0.3.0"]) | |||
| s.add_dependency "fog-core", "~>1.40" | |||
There was a problem hiding this comment.
Can we drop the extra fog-core dependency? That way it will evaluate to whatever the fog-* gems need?
There was a problem hiding this comment.
Good one, didn't realize we're enforcing it from here as well, thanks.
With this commit we shift fog-vcloud-director version to 0.3.0 which is fog-core 2.1.x compliant, but remains fog-core 1.45 compatible. Also, we omit the explicit fog-core requirement in vmware's Gemfile bacause we don't need it per se so we better let the fog-vcloud-director install whatever it needs. Fixes ManageIQ#319 Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
shift-fog-version
branch
from
a396ef6
to
8be144d
Compare
|
Checked commit miha-plesko@8be144d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
miha-plesko
changed the title
|
Marking as WIP temporarily, I want to test if provisioning works as well (inventoring does), but am having some issues due to UI change which prevents me from triggering the provisioning. Hopefully I'm done before Adam wakes up :) |
miha-plesko
changed the title
|
Works like a charm 👍 Needs #322 to get the vApp provisioning started, but this one can be merged independently. |
Shift fog-vcloud-director version to 0.3.0
…tirement_statemachines_methods_CheckDeletedFromProvider_method Refactoring cloud vm retirement check_deleted_from_provider method
With this commit we shift fog-vcloud-director version to 0.3.0 which is fog-core 2.1.x compliant, but remains fog-core 1.45 compatible.
Also, we omit the explicit fog-core requirement in vmware's Gemfile bacause we don't need it per se so we better let the fog-vcloud-director install whatever it needs.
Fixes #319
@miq-bot assign @agrare
@miq-bot add_label enhancement