Parse if a datastore is accessible from a host #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1668020_parse_datastore_accessible
branch
from
22930e3
to
976c85c
Compare
agrare
force-pushed
the
bz_1668020_parse_datastore_accessible
branch
5 times, most recently
from
329ff56
to
b36aa0b
Compare
2 tasks
gmcculloug
reviewed
Jan 24, 2019
| @@ -469,6 +469,13 @@ def assert_specific_host | |||
| :location => "4dce5b88-623e8e7e-0dc0-00188b404015" | |||
| ) | |||
|
|
|||
| expect(@host.host_storages.where(:accessible => false).count).to eq(1) | |||
| inaccessible_host_storage = @host.host_storages.where(:accessible => false).first | |||
There was a problem hiding this comment.
Minor, but you can use find_by(:accessible => false) and drop the .first on this call.
Parse if a datastore is able to be accessed from a host into the host_storage record. https://bugzilla.redhat.com/show_bug.cgi?id=1668020
agrare
force-pushed
the
bz_1668020_parse_datastore_accessible
branch
from
b36aa0b
to
01f506a
Compare
|
Checked commit agrare@01f506a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Jan 24, 2019
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jan 28, 2019
…e_accessible Parse if a datastore is accessible from a host (cherry picked from commit 4e2e9b8)
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse if a datastore is able to be accessed from a host into the
host_storage record.
Depends on:
https://bugzilla.redhat.com/show_bug.cgi?id=1668020