Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relations for distributed_virtual_switches #364

Merged
merged 11 commits into from
Feb 14, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 1, 2019

@miq-bot miq-bot added the wip label Feb 1, 2019
@agrare agrare force-pushed the update_distributed_switch_assoc branch 2 times, most recently from 0b8a18a to 322344c Compare February 4, 2019 18:33
@agrare agrare requested a review from Ladas February 5, 2019 01:11
@agrare
Copy link
Member Author

agrare commented Feb 5, 2019

cc @Ladas

@agrare agrare changed the title [WIP] Add relations for distributed_virtual_switches Add relations for distributed_virtual_switches Feb 5, 2019
@agrare agrare force-pushed the update_distributed_switch_assoc branch 3 times, most recently from f9e8f66 to df88b02 Compare February 8, 2019 17:58
@miq-bot miq-bot removed the wip label Feb 12, 2019
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, waiting for the dependency

@agrare agrare force-pushed the update_distributed_switch_assoc branch 2 times, most recently from 19fded8 to 740742e Compare February 13, 2019 20:40
@agrare agrare force-pushed the update_distributed_switch_assoc branch from 740742e to 64b084d Compare February 13, 2019 20:57
@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2019

Checked commits agrare/manageiq-providers-vmware@c08ab6b~...64b084d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 13 offenses detected

app/models/manageiq/providers/vmware/infra_manager.rb

app/models/manageiq/providers/vmware/infra_manager/distributed_virtual_switch.rb

app/models/manageiq/providers/vmware/infra_manager/inventory/parser/virtual_machine.rb

app/models/manageiq/providers/vmware/infra_manager/refresh_parser.rb

  • ⚠️ - Line 107, Col 35 - Lint/UriEscapeUnescape - URI.decode method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.
  • ⚠️ - Line 56, Col 11 - Lint/ShadowedArgument - Argument mor was shadowed by a local variable before it was used.
  • ⚠️ - Line 58, Col 18 - Lint/UriEscapeUnescape - URI.decode method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.
  • ⚠️ - Line 92, Col 27 - Lint/UnusedBlockArgument - Unused block argument - mor. If it's necessary, use _ or _mor as an argument name to indicate that it won't be used.
  • ❗ - Line 109, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('allowPromiscuous', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('allowPromiscuous', 'value').to_s.casecmp('true') == 0.
  • ❗ - Line 110, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('forgedTransmits', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('forgedTransmits', 'value').to_s.casecmp('true') == 0.
  • ❗ - Line 111, Col 35 - Style/NumericPredicate - Use security_policy.fetch_path('macChanges', 'value').to_s.casecmp('true').zero? instead of security_policy.fetch_path('macChanges', 'value').to_s.casecmp('true') == 0.
  • ❗ - Line 70, Col 66 - Style/NumericPredicate - Use allow_promiscuous.to_s.casecmp('true').zero? instead of allow_promiscuous.to_s.casecmp('true') == 0.
  • ❗ - Line 71, Col 65 - Style/NumericPredicate - Use forged_transmits.to_s.casecmp('true').zero? instead of forged_transmits.to_s.casecmp('true') == 0.
  • ❗ - Line 72, Col 60 - Style/NumericPredicate - Use mac_changes.to_s.casecmp('true').zero? instead of mac_changes.to_s.casecmp('true') == 0.

@agrare agrare reopened this Feb 14, 2019
@gtanzillo gtanzillo added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 14, 2019
@gtanzillo gtanzillo merged commit 25997b6 into ManageIQ:master Feb 14, 2019
@agrare agrare deleted the update_distributed_switch_assoc branch February 14, 2019 22:15
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants