Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prov dialogs from main repo #384

Merged

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Apr 2, 2019

I have RFE about adding thick_eager prov option in vmware dialogs. It requires changing the dialogs. As a first step, we should move the vmware prov dialogs to the vmware repo.

it's precursor to work for https://bugzilla.redhat.com/show_bug.cgi?id=1633867

Depends on: (merely for single test failure)

ManageIQ/manageiq#18614

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2019

@miq-bot add_label cleanup
@miq-bot assign @agrare
🎉 sorry Adam I dunno who else to give this lovely present to

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2019

@miq-bot add_reviewer @gmcculloug

@miq-bot miq-bot requested a review from gmcculloug April 2, 2019 14:04
@miq-bot
Copy link
Member

miq-bot commented Apr 2, 2019

Checked commit d-m-u@2ccd21f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 5 offenses detected

content/miq_dialogs/miq_provision_vmware_cluster_dialogs_template.yaml

  • ⚠️ - Line 103, Col 121 - 136 > 120 characters) (line-length - line too long

content/miq_dialogs/miq_provision_vmware_dialogs_clone_to_template.yaml

  • ⚠️ - Line 103, Col 121 - 136 > 120 characters) (line-length - line too long

content/miq_dialogs/miq_provision_vmware_dialogs_clone_to_vm.yaml

  • ⚠️ - Line 112, Col 121 - 136 > 120 characters) (line-length - line too long

content/miq_dialogs/miq_provision_vmware_dialogs_template.yaml

  • ⚠️ - Line 103, Col 121 - 136 > 120 characters) (line-length - line too long

content/miq_dialogs/miq_provision_vmware_folder_dialogs_template.yaml

  • ⚠️ - Line 103, Col 121 - 136 > 120 characters) (line-length - line too long

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2019

It's failing because it depends on the master one being merged first, is my guess

@gmcculloug gmcculloug merged commit 47eddc2 into ManageIQ:master Apr 2, 2019
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Options hash should not store Active Record objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants