Add thick_eager disk_format option #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
gmcculloug
changed the title
|
Checked commit d-m-u@3b5edab with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…vmattributes Add specs for Transformation - RestoreVmAttributes
d-m-u
changed the title
agrare
approved these changes
Aug 1, 2019
agrare
added a commit
that referenced
this pull request
Aug 1, 2019
Add thick_eager disk_format option
|
@miq-bot add_label ivanchuk/yes |
simaishi
pushed a commit
that referenced
this pull request
Aug 1, 2019
Add thick_eager disk_format option (cherry picked from commit 88a1411) https://bugzilla.redhat.com/show_bug.cgi?id=1633867
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For vmware disk_formats, we're missing an option at the moment.
The "... dialog field option should be updated so that the exist "thick" option remains, but the display value is updated to read "Thick - Lazy Zero". This supports backward-compatibility. Then a new options for "thick_eager" should be added."
#384 and ManageIQ/manageiq#18614 moved the vmware prov dialogs from main to the vmware repo, and this adds the option in the yaml files.
First half of work for https://bugzilla.redhat.com/show_bug.cgi?id=1633867