Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode the dvSwitch and dvPortgroup name #4

Merged
merged 3 commits into from
Feb 7, 2017
Merged

Decode the dvSwitch and dvPortgroup name #4

merged 3 commits into from
Feb 7, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 24, 2017

If dvSwitch and dvPortgroup names have a '/' in the name VMware will encode these as '%2f'
This will decode these names in the RefreshParser similar to what is done with VM names.

Before:
screenshot from 2017-01-24 15-27-44

After:
screenshot from 2017-01-24 15-30-31

https://bugzilla.redhat.com/show_bug.cgi?id=1411527

@agrare agrare added the bug label Jan 24, 2017
@agrare
Copy link
Member Author

agrare commented Jan 24, 2017

cc @gmcculloug @lfu

@gmcculloug
Copy link
Member

Looks good to me. This solves the issue for the UI as well as any calls from automate that set the network name since it will now be stored in the database decoded. 👍

@lfu
Copy link
Member

lfu commented Jan 25, 2017

LGTM 👍

@agrare
Copy link
Member Author

agrare commented Jan 25, 2017

cc @blomquisg

@agrare
Copy link
Member Author

agrare commented Feb 1, 2017

ping @blomquisg what do you think?

@blomquisg blomquisg merged commit 9597c98 into ManageIQ:master Feb 7, 2017
@blomquisg blomquisg added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
@agrare agrare deleted the bz_1411527_dvs_decode_name branch February 7, 2017 21:15
agrare added a commit to agrare/manageiq-providers-vmware that referenced this pull request Feb 27, 2017
@agrare
Fix spec tests for DVS
894fd98 
PRs ManageIQ#4 and ManageIQ#5 changed the name and key of the same DVS causing a
conflict and leading to the tests failing to find the Lan
@agrare agrare mentioned this pull request Feb 27, 2017
Merged
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017 •
edited
Loading

Euwe backport (to manageiq repo) details:

$ git log -1
commit bb7cd91b03a489225c9cac07a961d3502a3cc702
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Tue Feb 7 16:15:01 2017 -0500

    Merge pull request #4 from agrare/bz_1411527_dvs_decode_name
    
    Decode the dvSwitch and dvPortgroup name
    (cherry picked from commit 9597c98df2068c9889ffac288634e6dc01a8257e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1420442

agrare added a commit to agrare/manageiq-providers-vmware that referenced this pull request Mar 9, 2017
@agrare
Fix spec tests for DVS
bbd3744 
PRs ManageIQ#4 and ManageIQ#5 changed the name and key of the same DVS causing a
conflict and leading to the tests failing to find the Lan
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@Fryguy
Merge pull request ManageIQ#4 from mkanoor/cleanup_yaml
668c757 
Fixed yaml line terminators in a hand edited file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blomquisg blomquisg

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @gmcculloug @lfu @simaishi @blomquisg