Use the new VM's ems_ref instead of an annotation #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting a UUID to the annotations field check for the new vm's ems_ref. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724751
agrare
changed the title
It is possible that EmsRefresh can have a really early view of the VM without all final data populated by the time the CloneVM_Task completes which can lead to post-provision tasks failing if they depend on some data in the vm record. Waiting until the Ems' inventory date is at least as recent as the CloneVM_Task completeTime we guarantee that the VM record represents the final VM state.
agrare
force-pushed
the
bz_1724751_use_vm_ems_ref_to_find_in_vmdb
branch
from
98e837b
to
3c45a85
Compare
agrare
changed the title
|
@gmcculloug @Fryguy updated to include waiting for the ems last_inventory_date to be at least as new as the CloneVM_Task completeTime |
|
@Fryguy @gmcculloug thoughts? |
gmcculloug
reviewed
Jul 23, 2019
| task_props = ["info.state", "info.error", "info.result", "info.progress", "info.completeTime"] | ||
| task = vim.getMoProp(clone_task_mor, task_props) | ||
|
|
||
| case task&.info&.state |
There was a problem hiding this comment.
Overall this looks good. Since we are referencing task&.info in 5 places we should set that to a variable to avoid the lookup each time: task_info = task&.info
gmcculloug
reviewed
Jul 23, 2019
| end | ||
| # Check that the EMS inventory is as up to date as the CloneVM_Task completeTime | ||
| # to prevent issues with post-provision depending on data that isn't in VMDB yet | ||
| return if source.ext_management_system.last_inventory_date < phase_context[:clone_vm_task_completion_time] |
|
Checked commits agrare/manageiq-providers-vmware@e9604ba~...e91a334 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Jul 23, 2019
agrare
modified the milestones:
Sprint 116 Ending Jul 22, 2019,
Sprint 117 Ending Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting a UUID to the annotations field check for the new
vm's ems_ref.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724751