Add disk relocate spec for eagerlyScrub backing option #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Jul 17, 2019
app/models/manageiq/providers/vmware/infra_manager/provision/configuration/disk.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jul 17, 2019
app/models/manageiq/providers/vmware/infra_manager/provision/configuration/disk.rb
Outdated
Show resolved
Hide resolved
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
5 times, most recently
from
31d82db
to
91d2770
Compare
agrare
reviewed
Jul 18, 2019
app/models/manageiq/providers/vmware/infra_manager/provision/configuration/disk.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jul 18, 2019
|
|
||
| disks << dev | ||
| end | ||
| devs + get_new_disks |
There was a problem hiding this comment.
We might need to parse the raw devices so that they're in a consistent format with what get_new_disks returns
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
7 times, most recently
from
3333183
to
ae6c71c
Compare
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
from
ae6c71c
to
cd80ef2
Compare
agrare
reviewed
Jul 19, 2019
app/models/manageiq/providers/vmware/infra_manager/provision/configuration/disk.rb
Outdated
Show resolved
Hide resolved
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
4 times, most recently
from
c0f213a
to
ed94d05
Compare
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
4 times, most recently
from
530743f
to
5bd9cc8
Compare
|
@d-m-u this is feeling less super-wip, maybe just wip |
d-m-u
changed the title
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
3 times, most recently
from
d36dbe9
to
b3451c9
Compare
This was referenced Aug 1, 2019
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
from
b3451c9
to
494ed62
Compare
agrare
reviewed
Aug 1, 2019
| vim.virtualMachineByMor(source.ems_ref_obj) | ||
| def build_disk_relocate_spec(datastore) | ||
| VimArray.new('ArrayOfVirtualMachineRelocateSpecDiskLocator') do |relocate_spec_array| | ||
| (disks + get_new_disks).map do |disk| |
There was a problem hiding this comment.
@d-m-u does the response of get_new_disks have a .key ?
I also wonder if we even need a RelocateSpec for a new disk, it isn't being relocated and we could just set eagerlyScrub when we build the backing
d-m-u
force-pushed
the
adding_disk_relocate_spec
branch
from
494ed62
to
9aa6abb
Compare
|
Checked commit d-m-u@9aa6abb with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip |
d-m-u
changed the title
agrare
added a commit
that referenced
this pull request
Aug 1, 2019
Add disk relocate spec for eagerlyScrub backing option
|
@d-m-u see I told you it wouldn't be that hard 🤣 |
|
@miq-bot add_label ivanchuk/yes |
|
Weird github didn't mark this closed, closing |
simaishi
pushed a commit
that referenced
this pull request
Aug 1, 2019
Add disk relocate spec for eagerlyScrub backing option (cherry picked from commit fc2e1cf) https://bugzilla.redhat.com/show_bug.cgi?id=1633867
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMware has a third option for disk provisioning that we're not using.
For https://bugzilla.redhat.com/show_bug.cgi?id=1633867
note
thick eagerZero will exceed the max retries in the engine (> 500 of the 100 max), so if you want to see this work, you can change automate to do this:
in
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_state_machine.rbdef enforce_max_retries(f) return if f['max_retries'].blank? - return if f['max_retries'].to_i >= @workspace.root['ae_state_retries'].to_i - raise "number of retries <#{@workspace.root['ae_state_retries']}> exceeded maximum of <#{f['max_retries']}>" + #return if f['max_retries'].to_i >= @workspace.root['ae_state_retries'].to_i + #raise "number of retries <#{@workspace.root['ae_state_retries']}> exceeded maximum of <#{f['max_retries']}>" endRelated to
#385
ManageIQ/vmware_web_service#63