Remove the option for legacy refresh from vCloud

[agrare]

Remove the setting to allow for legacy refresh in vCloud and delete the
old parsers.

[miq-bot]

Checked commits agrare/manageiq-providers-vmware@b4cbe30~...ad90721 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
14 files checked, 18 offenses detected

app/models/manageiq/providers/vmware/cloud_manager/refresh_worker.rb

• ❗ - Line 14, Col 7 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

app/models/manageiq/providers/vmware/inventory/collector/network_manager.rb

• ❗ - Line 117, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 126, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 132, Col 3 - Layout/EmptyLineBetweenDefs - Use empty lines between method definitions.
• ❗ - Line 20, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 29, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 46, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 73, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 76, Col 9 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

app/models/manageiq/providers/vmware/inventory/parser/network_manager.rb

• ⚠️ - Line 23, Col 5 - Layout/EndAlignment - end at 23, 4 is not aligned with if at 19, 19.
• ❗ - Line 123, Col 5 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 151, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 20, Col 7 - Layout/IndentationWidth - Use 2 (not -13) spaces for indentation.
• ❗ - Line 21, Col 5 - Layout/ElseAlignment - Align else with if.
• ❗ - Line 45, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 45, Col 16 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

app/models/manageiq/providers/vmware/inventory/persister/definitions/network_collections.rb

• ❗ - Line 5, Col 5 - Style/PercentLiteralDelimiters - %i-literals should be delimited by [ and ].

app/models/manageiq/providers/vmware/inventory/persister/network_manager.rb

• ❗ - Line 11, Col 5 - Style/PercentLiteralDelimiters - %i-literals should be delimited by [ and ].