Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start_inventory_collector in do_before_work #428

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Don't start_inventory_collector in do_before_work #428

merged 1 commit into from
Aug 1, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 1, 2019

The very next thing that runs is do_work which will start the inventory
collector thread anyway.

@agrare
Don't start_inventory_collector in do_before_work
1561d0e 
The very next thing that runs is do_work which will start the inventory
collector thread anyway.
@agrare agrare added the cleanup label Aug 1, 2019
@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2019

Checked commit agrare@1561d0e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gtanzillo gtanzillo merged commit 1f859d5 into ManageIQ:master Aug 1, 2019
@agrare agrare deleted the dont_need_do_before_work_loop branch August 1, 2019 22:35
@agrare agrare added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 2, 2019
@agrare agrare mentioned this pull request Aug 2, 2019
Merged
simaishi pushed a commit that referenced this pull request Aug 2, 2019
@gtanzillo @simaishi
Merge pull request #428 from agrare/dont_need_do_before_work_loop
9e8451c 
Don't start_inventory_collector in do_before_work

(cherry picked from commit 1f859d5)
@simaishi
Copy link
Contributor

simaishi commented Aug 2, 2019

Ivanchuk backport details:

$ git log -1
commit 9e8451cbc4665a935dd29f2197afb9c471ab775e
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Aug 1 17:08:21 2019 -0400

    Merge pull request #428 from agrare/dont_need_do_before_work_loop
    
    Don't start_inventory_collector in do_before_work
    
    (cherry picked from commit 1f859d58f5fa247a9f04ce8a476c5bb4394e78fc)

simaishi pushed a commit that referenced this pull request Sep 5, 2019
@gtanzillo @simaishi
Merge pull request #428 from agrare/dont_need_do_before_work_loop
25504e5 
Don't start_inventory_collector in do_before_work

(cherry picked from commit 1f859d5)

https://bugzilla.redhat.com/show_bug.cgi?id=1737124
@simaishi
Copy link
Contributor

simaishi commented Sep 5, 2019

Hammer backport details:

$ git log -1
commit 25504e56a677bc666a34a99cf8daa5c1b23fee53
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Aug 1 17:08:21 2019 -0400

    Merge pull request #428 from agrare/dont_need_do_before_work_loop
    
    Don't start_inventory_collector in do_before_work
    
    (cherry picked from commit 1f859d58f5fa247a9f04ce8a476c5bb4394e78fc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1737124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
cleanup hammer/backported ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @simaishi @gtanzillo