Don't update ems attributes in refresh parser #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
Send the ems api_version and uid_ems to save_ems_inventory in hashes and remove a direct ems.update_attributes call in the refresh_parser.
agrare
force-pushed
the
dont_update_ems_in_refresh_parser
branch
from
c329028
to
3a9a095
Compare
|
Checked commits agrare/manageiq-providers-vmware@15e9e52~...3a9a095 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
commented
Jun 28, 2017
| @@ -54,14 +53,6 @@ def parse_targeted_inventory(ems, _target, inventory) | |||
| hashes | |||
| end | |||
|
|
|||
| def save_inventory(ems, target, hashes) | |||
| Benchmark.realtime_block(:db_save_inventory) do | |||
| # TODO: really wanna kill this @ems_data instance var | |||
There was a problem hiding this comment.
@blomquisg I think this was your comment :) Finally gone
|
👍 |
blomquisg
approved these changes
Jun 28, 2017
|
ping @blomquisg |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Fixes VM extend retirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse EMS attributes and send to save_ems_inventory instead of updating directly in the refresh_parser and finally kill the
@ems_datavariable.Depends: ManageIQ/manageiq#15252