Don't queue a refresh on RefreshWorker start #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refresh_worker is restarted every 2 hours, by queueing a full refresh everytime the refresh_worker starts this was causing a significant number more full refreshes than before. https://bugzilla.redhat.com/show_bug.cgi?id=1469198
|
Checked commit agrare@3deafbe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
deleted the
bz_1469198_dont_run_queue_full_refresh_every_refresh_worker_start
branch
|
Euwe backport (to manageiq repo) details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2017
…resh_every_refresh_worker_start Don't queue a refresh on RefreshWorker start (cherry picked from commit 26ae511) https://bugzilla.redhat.com/show_bug.cgi?id=1479886
|
Fine backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Changelog 57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refresh_worker is restarted every 2 hours, by queueing a full refresh everytime the refresh_worker starts this was causing a significant number more full refreshes than before.
This was originally done in #41 so that when a user added additional EMSs an initial refresh would be queued, but that combined with us restarting the refresh worker every 2 hours caused many more full refreshes than intended.
https://bugzilla.redhat.com/show_bug.cgi?id=1469198