Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only collect storage profile datastores on full refresh #83

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 21, 2017

With a lot of storage profiles the time to get the datastores for profiles take a huge amount of time even on targeted refreshes. This will only collect the associated datastores on full refreshes to keep the targeted time down.

{
 :pbmProfilesByUid=>0.6636569499969482,
 :pbmQueryMatchingHub=>2148.5395801067352,
 :pbmQueryAssociatedEntity=>2.737989664077759,
 :collect_storage_profiles=>2151.941283226013
}

https://bugzilla.redhat.com/show_bug.cgi?id=1473379

@agrare
Copy link
Member Author

agrare commented Jul 21, 2017

cc @blomquisg

@agrare agrare force-pushed the bz_1473379_only_collect_storage_profiles_full_refresh branch 3 times, most recently from 7914d90 to 6f6e0ee Compare July 26, 2017 20:06
The collection of storage profiles can take a long time and cannot be
filtered by target causing targeted refreshes to take significantly
longer under certain circumstances.

https://bugzilla.redhat.com/show_bug.cgi?id=1473379
@agrare agrare force-pushed the bz_1473379_only_collect_storage_profiles_full_refresh branch from 6f6e0ee to 9c61631 Compare July 27, 2017 16:47
@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commit agrare@9c61631 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@agrare
Copy link
Member Author

agrare commented Aug 3, 2017

ping @blomquisg

@blomquisg blomquisg merged commit 9921ecb into ManageIQ:master Aug 8, 2017
@blomquisg blomquisg added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 8, 2017
@agrare agrare deleted the bz_1473379_only_collect_storage_profiles_full_refresh branch August 8, 2017 14:30
simaishi pushed a commit that referenced this pull request Aug 14, 2018
…ofiles_full_refresh

Only collect storage profile datastores on full refresh
(cherry picked from commit 9921ecb)

https://bugzilla.redhat.com/show_bug.cgi?id=1593914
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 3e6419dbd31bb17244e999ff5660252a631a37ca
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Tue Aug 8 10:29:35 2017 -0400

    Merge pull request #83 from agrare/bz_1473379_only_collect_storage_profiles_full_refresh
    
    Only collect storage profile datastores on full refresh
    (cherry picked from commit 9921ecbdff1d024bd4801fe188a3cd5843e300ad)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1593914

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Move runtime dependency from ManageIQ/manageiq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants