Add vm_acquire_ticket for webmks console types #9
Conversation
| def vm_acquire_ticket(vm, options = {}) | ||
| invoke_vim_ws(:acquireTicket, vm, options[:user_event], options[:ticket_type]) | ||
| end | ||
| alias_method :vm_remote_console_acquire_ticket, :vm_acquire_ticket |
There was a problem hiding this comment.
Do we really need this alias? I would rather create a vm_remote_console_webmks_acquire_ticket wrapper with a hardcoded ticket_type.
There was a problem hiding this comment.
Yeah that works, and actually AcquireMksTicket is deprecated as of 4.1 so we can make that a wrapper around this with the mks ticket type
There was a problem hiding this comment.
So the alias for mks is used here https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/vm/remote_console.rb#L44
Is there a reason to use the alias and not the main method?
There was a problem hiding this comment.
As i look at it, this has probably been done for some symmetry...
There was a problem hiding this comment.
Okay I added a method to get webmks tickets specifically so you don't need to pass a :ticket_type in options
Automate - Enhanced messaging for Ansible and Cloud provisioning.
Add a method to acquire a webmks ticket for a VMware vm using the
VirtualMachine#AcquireTicketmethodDepends on: ManageIQ/manageiq-gems-pending#59
ManageIQ/manageiq#13798