Initial attempt at Github Actions #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
reviewed
Dec 17, 2021
| echo "REGISTRY_PASSWORD=${{ secrets.REGISTRY_PASSWORD }}" >> $GITHUB_ENV | ||
| echo "REGISTRY_USERNAME=${{ secrets.REGISTRY_USERNAME }}" >> $GITHUB_ENV | ||
| - name: Run container build script | ||
| run: bin/build_container_image |
There was a problem hiding this comment.
Is this doing a build on pull requests in addition to pushes?
There was a problem hiding this comment.
Yes, it builds on every PR, but only pushes to the registry on merges
There was a problem hiding this comment.
I split it so that the credentials shouldn't even show up on PR run.
bdunne
force-pushed
the
initial_github_actions
branch
from
cb688d0
to
4c20866
Compare
|
Checked commit bdunne@4c20866 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint **
|
jrafanie
reviewed
Dec 17, 2021
| run: | | ||
| echo "TRAVIS_PULL_REQUEST=${{ github.base_ref == '' && 'false' || 'true' }}" >> $GITHUB_ENV | ||
| - name: Set up registry credentials | ||
| if: ${{ github.base_ref == '' }} |
There was a problem hiding this comment.
I'm guessing this is the "if not a PR" logic, right?
There was a problem hiding this comment.
Yes, that's the closest thing I could find for it.
This was referenced Dec 17, 2021
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jan 25, 2022
(cherry picked from commit f7ad87c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: ManageIQ/manageiq#21620
I'll open a follow-up to remove the Travis config