Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TRAVIS env vars #240

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Fix TRAVIS env vars #240

merged 1 commit into from
Dec 20, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Dec 20, 2021

@bdunne Please review. Alternative to #239 using the techniques in https://developer.okta.com/blog/2020/05/18/travis-ci-to-github-actions

Fryguy
Fryguy commented Dec 20, 2021
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Fryguy
Fryguy commented Dec 20, 2021
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@Fryguy Fryguy force-pushed the fix_travis_env branch 3 times, most recently from 82283c2 to 0b8bf34 Compare December 20, 2021 17:56
Fryguy
Fryguy commented Dec 20, 2021
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Fryguy
Fryguy commented Dec 20, 2021
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@Fryguy Fryguy added the test label Dec 20, 2021
@Fryguy Fryguy mentioned this pull request Dec 20, 2021
Closed
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2021

Checked commit Fryguy@44d661b with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy Fryguy mentioned this pull request Dec 20, 2021
Merged
@bdunne bdunne merged commit 44fbe20 into ManageIQ:master Dec 20, 2021
@Fryguy Fryguy deleted the fix_travis_env branch December 20, 2021 20:35
@Fryguy Fryguy mentioned this pull request Dec 21, 2021
Closed
@Fryguy
Copy link
Member Author

Fryguy commented Jan 25, 2022

Backported to morphy in commit ae49f8e.

commit ae49f8e35f88bc89987fa4fb780681dae22ab9ed
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Dec 20 15:10:44 2021 -0500

    Merge pull request #240 from Fryguy/fix_travis_env
    
    Fix TRAVIS env vars
    
    (cherry picked from commit 44fbe2076e710d5106fb37a99b27589fa0843996)

Fryguy pushed a commit that referenced this pull request Jan 25, 2022
@bdunne @Fryguy
Merge pull request #240 from Fryguy/fix_travis_env
ae49f8e 
Fix TRAVIS env vars

(cherry picked from commit 44fbe20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

Assignees

@bdunne bdunne

Labels
morphy/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryguy @miq-bot @bdunne