Temporarily fix CI by setting total_space for the mocked storage #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@4486046 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
Closing in favor of ManageIQ/manageiq#20937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for making the CI happy, since ManageIQ/manageiq#20871 was merged into core. The
Storage#total_spacecan returnnilwhich causes thezero?method to fail which is a problem when testing thereport_dataof storages. As this problem might affect other callsites as well so IMO it should be fixed in the model. If I'm wrong, then we might want to add a dummy value into the storage factory for the tests to stay happy.FYI @djberg96 @Fryguy