diff --git a/app/models/service.rb b/app/models/service.rb index aadae8a127b..8c72c7d59b1 100644 --- a/app/models/service.rb +++ b/app/models/service.rb @@ -58,6 +58,7 @@ class Service < ApplicationRecord delegate :provision_dialog, :to => :miq_request, :allow_nil => true delegate :user, :to => :miq_request, :allow_nil => true + include CustomActionsMixin include ServiceMixin include OwnershipMixin include CustomAttributeMixin @@ -104,12 +105,14 @@ def power_states vms.map(&:power_state) end + # renaming method from custom_actions_mixin + alias_method :custom_service_actions, :custom_actions def custom_actions - service_template&.custom_actions(self) + service_template ? service_template.custom_actions(self) : custom_service_actions(self) end def custom_action_buttons - service_template&.custom_action_buttons(self) + service_template ? service_template.custom_action_buttons(self) : generic_custom_buttons end def power_state diff --git a/spec/models/service_spec.rb b/spec/models/service_spec.rb index 64b4f312fff..81eff9dfd4d 100644 --- a/spec/models/service_spec.rb +++ b/spec/models/service_spec.rb @@ -826,17 +826,36 @@ def create_deep_tree let(:service_template) { FactoryGirl.create(:service_template) } let(:service) { FactoryGirl.create(:service, :service_template => service_template) } - describe "#custom_actions" do - it "get list of custom actions from linked service template" do - expect(service_template).to receive(:custom_actions) - service.custom_actions + context "with template" do + describe "#custom_actions" do + it "get list of custom actions from linked service template" do + expect(service_template).to receive(:custom_actions) + service.custom_actions + end + end + + describe "#custom_action_buttons" do + it "get list of custom action buttons from linked service template" do + expect(service_template).to receive(:custom_action_buttons) + service.custom_action_buttons + end end end - describe "#custom_action_buttons" do - it "get list of custom action buttons from linked service template" do - expect(service_template).to receive(:custom_action_buttons) - service.custom_action_buttons + context "without template" do + let!(:custom_button) { FactoryGirl.create(:custom_button, :applies_to_class => "Service") } + let(:service) { FactoryGirl.create(:service, :service_template_id => -1) } + + describe "#custom_action_buttons" do + it "get list of custom action buttons on services" do + expect(service.custom_action_buttons).to include(custom_button) + end + end + + describe "#custom_actions" do + it "get list of custom actions on services" do + expect(service.custom_actions).to include(:buttons => [a_hash_including("id" => custom_button.id)], :button_groups => []) + end end end end