From 6f23bdc6b54c638748b7ce925c4971dc7b7595af Mon Sep 17 00:00:00 2001
From: Nick LaMuro <nicklamuro@gmail.com>
Date: Mon, 3 Feb 2020 21:37:27 -0600
Subject: [PATCH] [MiqReport::Generator] Avoid polymorphic to Rbac

This changes what is passed to Rbac from MiqReport::Generator to avoid
passing keys for includes/references that are polymorphic in nature.

This means that there might be a bit of a performance degradation on
some reports, but for now stability is being favored over performance.

Follow up:  For the keys that are skipped, a MiqPreload should probably
be called to avoid N+1 calls, but unsure where the best for this would
be.
---
 app/models/miq_report/generator.rb | 32 ++++++++++++++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/app/models/miq_report/generator.rb b/app/models/miq_report/generator.rb
index b0055fc685ec..ee93eab2d7c6 100644
--- a/app/models/miq_report/generator.rb
+++ b/app/models/miq_report/generator.rb
@@ -88,6 +88,34 @@ def get_include
     include_as_hash(include.presence || invent_report_includes)
   end
 
+  def polymorphic_includes
+    @polymorphic_includes ||= begin
+      polymorphic_rels = []
+      top_level_rels   = []
+      top_level_rels  += Array(get_include.try(:keys))
+      top_level_rels  += Array(get_include_for_find.try(:keys))
+
+      top_level_rels.uniq.each do |assoc|
+        reflection = db_klass.reflect_on_association(assoc)
+        polymorphic_rels << assoc if reflection && reflection.polymorphic?
+      end
+
+      polymorphic_rels
+    end
+  end
+
+  def get_include_for_find_rbac
+    polymorphic_includes.each_with_object(get_include_for_find.dup) do |key, includes|
+      includes.delete(key)
+    end
+  end
+
+  def get_include_rbac
+    polymorphic_includes.each_with_object(get_include.dup) do |key, includes|
+      includes.delete(key)
+    end
+  end
+
   def invent_includes
     include_as_hash(invent_report_includes)
   end
@@ -312,8 +340,8 @@ def generate_basic_results(options = {})
     rbac_opts = options.merge(
       :targets          => targets,
       :filter           => conditions,
-      :include_for_find => get_include_for_find,
-      :references       => get_include,
+      :include_for_find => get_include_for_find_rbac,
+      :references       => get_include_rbac,
       :where_clause     => where_clause,
       :skip_counts      => true
     )