Handle setup playbook failure better #15313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
changed the title
Previously if we had a value in the database, but the file didn't exist on the filesystem .configured? would raise an error when it should really just return false and we will write out the value from the database to the filesystem. https://bugzilla.redhat.com/show_bug.cgi?id=1439783 https://bugzilla.redhat.com/show_bug.cgi?id=1458886
This will force `.configured?` to false the next time `.start` is run allowing us to retry the configuration. Before this change, users would have to blank the SECRET_KEY file on the filesystem to force a retry. https://bugzilla.redhat.com/show_bug.cgi?id=1439783 https://bugzilla.redhat.com/show_bug.cgi?id=1458886
carbonin
force-pushed
the
handle_setup_playbook_failure_better
branch
from
248c8c7
to
f80e6dd
Compare
|
Checked commits carbonin/manageiq@42eb2f8~...f80e6dd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
changed the title
|
|
LGTM
simaishi
pushed a commit
that referenced
this pull request
Jun 12, 2017
…_better Handle setup playbook failure better (cherry picked from commit 388a40c) https://bugzilla.redhat.com/show_bug.cgi?id=1460803 https://bugzilla.redhat.com/show_bug.cgi?id=1460805
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to re-run the setup playbook if we fail the first time around.
When #15225 made us run the setup playbook only once, it had a side-effect of not allowing us to run the playbook again if and when we failed the first time.
This PR handles that situation by removing the secret key from the database when the playbook run fails. This in turn causes
EmbeddedAnsible.configured?to return false the next time we attempt to run the playbook.https://bugzilla.redhat.com/show_bug.cgi?id=1439783
https://bugzilla.redhat.com/show_bug.cgi?id=1458886