Modify MiqAction so that queue_name is set for ems operations #19652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits https://github.com/djberg96/manageiq/compare/96e03789abf6dfae907cd695ead8afcf377c92cf~...a75842b8c65cb41b628141554c3aece68c3921af with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
Dec 19, 2019
agrare
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the private method
invoke_or_queueso that it will set the queue_name whenever the role is an ems operation.The name is set using the target's queue name for ems operations, or "generic" if that's not possible. In most cases the target and the rec are the same for ems operations. Only
action_vm_retireactually has a different target and would have to default as far as I could tell.I updated the specs a bit to include one of the other operations besides
action_vm_retireas well.Part of #19543
Cross-repo tests at ManageIQ/manageiq-cross_repo-tests#41