Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VimPerformanceState#vim_performance_state_for_ts optimizations #22611

Merged
merged 4 commits into from
Aug 1, 2023
Merged

VimPerformanceState#vim_performance_state_for_ts optimizations #22611

merged 4 commits into from
Aug 1, 2023

Commits on Jul 15, 2023

  1. comments on passing times around

    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    0d34281 View commit details
    Browse the repository at this point in the history

  2. vim_performance_state_for_ts(Time) 

    defaulting to passing time into the method.
Places calling it, ensure that

Fixing:

sometimes we were passing non iso8061 into the method
so it was not finding the cached VimPerformanceState records

|       ms |       bytes |   objects |query |  qry ms |     rows |` comments`
|      ---:|         ---:|       ---:|  ---:|     ---:|      ---:|  ---
|  1,699.1 | 19,618,021* |   283,526 |    9 | 1,519.6 |       79 |`before`
|  1,664.1 | 15,672,327* |   225,826 |    5 | 1,550.8 |       75 |`after-fetch-time`
    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    5280baf View commit details
    Browse the repository at this point in the history

  3. Don't lookup previously created VimPerformanceState 

    wanted to create specs around vim_performance_state_association and hit a tangent.

This already cached newly created vim_performance_state records when one did not exist in the db
but it never looked for that value in the local cache.

now it looks that value up
    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    5a9de94 View commit details
    Browse the repository at this point in the history

  4. vim_performance_state_for_ts - don't find(now) 

    since perf_capture_state does a find for now, not reason to try and find it first
have tried to remove this extra query a few times.

previous attempts deleted this line.
this one is different as we added the unless. there were a few cases that we do
want a find here. (luckily there are tests around this)
    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e6268fc View commit details
    Browse the repository at this point in the history